Clean Code

public void set(String s) {
booleanValue = true;
}
}
And finally I replaced the call to 
setBoolean
with a call to 
set
.
private void setBooleanArg(char argChar, boolean value) {
booleanArgs.get(argChar)
.set("true");
}
The tests all still passed. Because this change caused 
set
to be deployed to the 
Boolean-
ArgumentMarshaler
, I removed the 
setBoolean
method from the 
ArgumentMarshaler
base
class.
Notice that the abstract 
set
function takes a 
String
argument, but the implementation
in the 
BooleanArgumentMarshaller
does not use it. I put that argument in there because I
knew that the 
StringArgumentMarshaller
and 
IntegerArgumentMarshaller
would
use it. 

---

218
Chapter 14: Successive Refinement
Next, I wanted to deploy the 
get
method into 
BooleanArgumentMarshaler
. Deploying
get
functions is always ugly because the return type has to be 
Object
, and in this case
needs to be cast to a 
Boolean
.
public boolean getBoolean(char arg) {
Args.ArgumentMarshaler am = booleanArgs.get(arg);
return am != null && 
(Boolean)
am.
get
();
}
Just to get this to compile, I added the 
get
function to the 
ArgumentMarshaler
.
private abstract class ArgumentMarshaler {
...
public Object get() {
return null;
}
}
This compiled and obviously failed the tests. Getting the tests working again was simply a
matter of making 
get
abstract and implementing it in 
BooleanAgumentMarshaler
.
private abstract class ArgumentMarshaler {
protected boolean booleanValue = false;
...
public 
abstract
Object get();
}
private class BooleanArgumentMarshaler extends ArgumentMarshaler {
public void set(String s) {
booleanValue = true;
}